Repository navigation
accepting --assume-rbr, remove SUPER requirement - #156
Conversation
- avoiding need to restart replication - in turn avoiding need for SUPER
|
Normally I would call this 👍 |
|
Hi @shlomi-noach, have you considered the approach of detecting whether Something like this:
If the event arrives as a This may be out of scope of the actual PR, and I can open an issue if you prefer to have the discussion there. PS. Kudos on coming up with such a novel approach to live schema changes. |
|
@pbitty this is a good suggestion, thank you! It may complicate stuff a bit, but seems worthwhile. I think I might first iterate with |
|
@SuperQ |
|
Maybe we can file a feature request upstream to extend the SHOW SLAVE STATUS to include the binlog mode for the running thread. |
|
👍 Nice |
|
Noting down that in the event I'm actually good to merge this, and iterate later with double-safety checks, such as:
|
|
Need to add documentation:
|
- introducing --assume-rbr - discussing the implication of being able to run without SUPER
--assume-rbr--assume-rbr, remove SUPER requirement
Related issue: #132
Avoid restarting replication, avoid need for SUPER
gh-ostcannot verify the replication thread truly usesRBR, and wishes to restart replication (stop slave; start slave;). However that requiresSUPERprivilege.This PR supports
--assume-rbrwhere the user clearly indicates "yes, this is truly and really RBR, and the replica is using RBR". Ifbinlog_format=ROWthengh-ostis happy to proceed without restarting replication, hence without requiringSUPERprivilege.This PR [briefly explain what is does]
gofmt(please avoidgoimports)./build.sh