Repository navigation
Add legal review triggers instructions - #6501
WillieDustice wants to merge 3 commits into
Conversation
🔒 PR Risk Scan ResultsScanned 1 changed file(s).
✅ No matching risk patterns were detected in changed files.
|
🚦 Submission status: 👀 Ready for reviewRisk tier: Why this tier
Automated checks
Review
Commands
Updated for |
There was a problem hiding this comment.
🟡 Changes recommended
The routine-work exemption conflicts with explicit legal-review triggers and can suppress relevant flags, while the pause rule lacks documented Copilot testing.
2 open issues
What changed in this PR
Adds a reusable Copilot instruction resource that flags changes potentially needing legal review while aiming to leave routine development uninterrupted.
Changes:
- Defines triggers covering AI features, agent actions, data use, analytics, payments, and audience changes.
- Directs Copilot to briefly flag qualifying changes and defer to the developer without giving legal advice.
- Adds the resource to the instructions catalog with installation links.
| File | Description |
|---|---|
instructions/legal-review-triggers.instructions.md |
Adds legal-review triggers, routine-work exclusions, and source attribution. |
docs/README.instructions.md |
Lists the new instructions with a description and installation links. |
Review effort: Balanced (adaptive)
| - Before building, merging, or launching a change, check whether it matches one of the triggers below. | ||
| - If it matches, pause that part of the work and tell the developer that it may need review by a licensed lawyer before it ships. Name the trigger and explain why in one or two sentences. Let them decide how to proceed. |
There was a problem hiding this comment.
🔵 Needs a closer look
Required GitHub Copilot testing remains unchecked, with no recorded results showing that triggering changes prompt escalation while routine changes proceed uninterrupted.
1 open issue
1 resolved since last review
Review effort: Balanced (adaptive)
|
Thanks for the review. Both points are addressed. Routine-work exemption: fixed in f81b53c. Routine work is skipped only when a change matches no trigger and every catch-all question is answered no, and a trigger always wins (for example, switching model providers or removing a confirmation step). Copilot testing: tested with GitHub Copilot CLI 1.0.114 (default model), with the file in
Testing found one gap: in the first run, Copilot flagged the provider swap but made the change anyway. I tightened the pause rule in af2c8c5 ("don't make that part of the change yet ... wait for the developer to say how to proceed"), and the results above are from that final version. |
There was a problem hiding this comment.
🟡 Changes recommended
The repository-wide pause rule lacks recorded Copilot usage results validating provider-change pauses, routine-work exclusions, and continuation after explicit developer instructions.
2 open issues
Review effort: Balanced (adaptive)
| ## Instructions | ||
|
|
||
| - Before building, merging, or launching a change, check whether it matches one of the triggers below. | ||
| - If it matches, don't make that part of the change yet. Tell the developer that it may need review by a licensed lawyer before it ships, name the trigger, and explain why in one or two sentences. Wait for the developer to say how to proceed, even if the change looks small. |


Pull Request Checklist
npm startand verified thatREADME.mdis up to date.mainbranch for this pull request.Description
Adds instructions that help Copilot notice when a planned change usually warrants review by a licensed lawyer before it ships, such as sending user data to a new AI provider, letting an agent spend money, or collecting children's or health data, and flag it to the developer instead of building past it. Routine work is explicitly excluded, so it doesn't add noise to everyday changes.
The trigger list is adapted from the open counsel-triggers list (CC BY 4.0, https://github.com/mandate-law/counsel-triggers). Disclosure: I'm a lawyer admitted in DC, and my firm maintains that list. The instructions are firm-neutral and don't point to any particular provider.
Copilot testing
Tested with GitHub Copilot CLI 1.0.114 (default model), with the file in
.github/instructions/of a small sample Node/React app. Each case started from a clean copy; the resume case continued the first session.Testing found one gap: in the first run, Copilot flagged the provider swap but made the change anyway. The pause rule was tightened in af2c8c5 ("don't make that part of the change yet ... wait for the developer to say how to proceed"), and the results above are from that final version.
Type of Contribution
Additional Notes
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.