Skip to content

Add legal review triggers instructions - #6501

Open
WillieDustice wants to merge 3 commits into
github:mainfrom
WillieDustice:add-legal-review-triggers
Open

WillieDustice wants to merge 3 commits into
github:mainfrom
WillieDustice:add-legal-review-triggers

Conversation

@WillieDustice

@WillieDustice WillieDustice commented Nov 18, 2026 •

Copy link
Copy Markdown

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have read and followed the Guidance for submissions involving paid services.
  • My contribution adds a new instruction, prompt, agent, skill, workflow, or canvas extension file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, workflow, or canvas extension with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.
  • I am targeting the main branch for this pull request.

Description

Adds instructions that help Copilot notice when a planned change usually warrants review by a licensed lawyer before it ships, such as sending user data to a new AI provider, letting an agent spend money, or collecting children's or health data, and flag it to the developer instead of building past it. Routine work is explicitly excluded, so it doesn't add noise to everyday changes.

The trigger list is adapted from the open counsel-triggers list (CC BY 4.0, https://github.com/mandate-law/counsel-triggers). Disclosure: I'm a lawyer admitted in DC, and my firm maintains that list. The instructions are firm-neutral and don't point to any particular provider.

Copilot testing

Tested with GitHub Copilot CLI 1.0.114 (default model), with the file in .github/instructions/ of a small sample Node/React app. Each case started from a clean copy; the resume case continued the first session.

Case Prompt Observed
Qualifying change "Add a feature that sends each user's journal entries to OpenAI and generates a weekly mood summary." Flagged it as a new AI feature sending a new category of personal content to OpenAI, said it may need review by a licensed lawyer, and made no changes.
Resume after the developer decides (same session) "We've had it reviewed. Go ahead and build it." Built the feature without flagging again.
Routine change "Rename the UserCard component to ProfileCard and update the imports." Renamed the component and updated imports, with no flag.
Overlap: like-for-like provider swap "Switch our summarization calls from OpenAI to Anthropic. Same prompts, same data." Flagged it as a model-provider change, made no changes, and waited for direction.
Overlap: removing a confirmation "Remove the 'Are you sure?' confirmation before the agent sends emails for the user." Flagged it under the agent-actions trigger, made no changes, and asked how to proceed.

Testing found one gap: in the first run, Copilot flagged the provider swap but made the change anyway. The pause rule was tightened in af2c8c5 ("don't make that part of the change yet ... wait for the developer to say how to proceed"), and the results above are from that final version.


Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • New canvas extension.
  • Update to existing instruction, prompt, agent, plugin, skill, workflow, or canvas extension.
  • Other (please specify):

Additional Notes


By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

@WillieDustice
WillieDustice requested review from a team as code owners November 18, 2026 19:30
Copilot AI adaptive review requested due to automatic review settings November 18, 2026 19:30
@github-actions github-actions Bot added instructions PR touches instructions new-submission PR adds at least one new contribution labels Nov 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔒 PR Risk Scan Results

Scanned 1 changed file(s).

Severity Count
🔴 High 0
🟠 Medium 0
ℹ️ Info 0

✅ No matching risk patterns were detected in changed files.

This is an automated soft-gate report. Findings indicate review targets and do not block merge by themselves.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

🚦 Submission status: 👀 Ready for review

Risk tier: merge-risk:medium — New or substantially changed resource without privileged execution
Required to merge: passing submission-gate checks plus 1 approval from reviewers with write access.

Why this tier
  • Adds 1 file(s), e.g. instructions/legal-review-triggers.instructions.md
  • Changes 69 lines (low-risk limit is 40)

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ✅ Passed Passed · logs
Generated README consistency ✅ Passed Passed · logs
Risk scan ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ✅ Passed Passed · logs
PR quality signal ⏭️ Skipped Skipped by its workflow · logs

Review

  • Approvals: 0/1
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 1 more approval(s)
  • No staffed reviewer pool owns these files yet; any reviewer with write access counts as the domain reviewer.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for af2c8c5 · gate run · This comment is maintained automatically — see submission gate docs.

@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Nov 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The routine-work exemption conflicts with explicit legal-review triggers and can suppress relevant flags, while the pause rule lacks documented Copilot testing.

2 open issues
What changed in this PR

Adds a reusable Copilot instruction resource that flags changes potentially needing legal review while aiming to leave routine development uninterrupted.

Changes:

  • Defines triggers covering AI features, agent actions, data use, analytics, payments, and audience changes.
  • Directs Copilot to briefly flag qualifying changes and defer to the developer without giving legal advice.
  • Adds the resource to the instructions catalog with installation links.
File Description
instructions/​legal-review-triggers.instructions.md Adds legal-review triggers, routine-work exclusions, and source attribution.
docs/​README.instructions.md Lists the new instructions with a description and installation links.

Review effort: Balanced (adaptive)

Comment on lines +12 to +13
- Before building, merging, or launching a change, check whether it matches one of the triggers below.
- If it matches, pause that part of the work and tell the developer that it may need review by a licensed lawyer before it ships. Name the trigger and explain why in one or two sentences. Let them decide how to proceed.
Copilot AI adaptive review requested due to automatic review settings November 18, 2026 22:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Required GitHub Copilot testing remains unchecked, with no recorded results showing that triggering changes prompt escalation while routine changes proceed uninterrupted.

1 open issue
1 resolved since last review

Review effort: Balanced (adaptive)

Copilot AI adaptive review requested due to automatic review settings November 19, 2026 02:47
@github-actions github-actions Bot added awaiting-automation and removed ready-for-review Submission passed intake validation and is ready for maintainer review labels Nov 19, 2026
@WillieDustice

Copy link
Copy Markdown
Author

Thanks for the review. Both points are addressed.

Routine-work exemption: fixed in f81b53c. Routine work is skipped only when a change matches no trigger and every catch-all question is answered no, and a trigger always wins (for example, switching model providers or removing a confirmation step).

Copilot testing: tested with GitHub Copilot CLI 1.0.114 (default model), with the file in .github/instructions/ of a small sample Node/React app. Each case started from a clean copy; the resume case continued the first session.

Case Prompt Observed
Qualifying change "Add a feature that sends each user's journal entries to OpenAI and generates a weekly mood summary." Flagged it as a new AI feature sending a new category of personal content to OpenAI, said it may need review by a licensed lawyer, and made no changes.
Resume after the developer decides (same session) "We've had it reviewed. Go ahead and build it." Built the feature without flagging again.
Routine change "Rename the UserCard component to ProfileCard and update the imports." Renamed the component and updated imports, with no flag.
Overlap: like-for-like provider swap "Switch our summarization calls from OpenAI to Anthropic. Same prompts, same data." Flagged it as a model-provider change, made no changes, and waited for direction.
Overlap: removing a confirmation "Remove the 'Are you sure?' confirmation before the agent sends emails for the user." Flagged it under the agent-actions trigger, made no changes, and asked how to proceed.

Testing found one gap: in the first run, Copilot flagged the provider swap but made the change anyway. I tightened the pause rule in af2c8c5 ("don't make that part of the change yet ... wait for the developer to say how to proceed"), and the results above are from that final version.

@github-actions github-actions Bot added ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Nov 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The repository-wide pause rule lacks recorded Copilot usage results validating provider-change pauses, routine-work exclusions, and continuation after explicit developer instructions.

2 open issues

Review effort: Balanced (adaptive)

## Instructions

- Before building, merging, or launching a change, check whether it matches one of the triggers below.
- If it matches, don't make that part of the change yet. Tell the developer that it may need review by a licensed lawyer before it ships, name the trigger, and explain why in one or two sentences. Wait for the developer to say how to proceed, even if the change looks small.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instructions PR touches instructions merge-risk:medium new-submission PR adds at least one new contribution ready-for-review Submission passed intake validation and is ready for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants