Repository navigation
[GHSA-9v3m-8fp8-mj99] Bootstrap Vulnerable to Cross-Site Scripting - #11391
yusuke-koyoshi wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
An active moderate finding remains because marking 3.4.1 as fixed leaves vulnerable releases 3.4.1–3.4.2 outside the affected range; the fixed event should be 3.4.3.
1 open issue
What changed in this PR
Expands GHSA-9v3m-8fp8-mj99 coverage to additional Maven WebJars distributions that repackage vulnerable Bootstrap and Bootstrap Sass JavaScript.
Changes:
- Adds npm and Bower Bootstrap WebJars for Bootstrap 3.x and 4.x.
- Adds standard, npm, and Bower Bootstrap Sass WebJars, including the unpatched Bower range through 3.3.7.
- Updates affected-package metadata and the advisory modification timestamp.
| File | Description |
|---|---|
| advisories/github-reviewed/2019/02/GHSA-9v3m-8fp8-mj99/GHSA-9v3m-8fp8-mj99.json | Extends the advisory's affected-package metadata with additional Bootstrap and Bootstrap Sass Maven WebJars distributions and their version ranges. |
Review effort: Lite (adaptive)
| "introduced": "3.0.0" | ||
| }, | ||
| { | ||
| "fixed": "3.4.1" |
There was a problem hiding this comment.
I think 3.4.1 is correct as the fixed version here.
org.webjars.npm:bootstrap-sass has 3.3.5, 3.3.6, 3.3.7, 3.4.1 and 3.4.3 on Maven Central; there is no 3.4.2 release. The 3.4.1 jar already contains the tooltip sanitizer (sanitizeHtml): its tooltip.js is byte-identical to npm bootstrap 3.4.1 js/tooltip.js, and 3.4.3 has the same code. 3.3.7 does not have it. So 3.4.1 is the first patched version for this package, consistent with the existing npm bootstrap-sass entry (>= 3.0.0, < 3.4.1).
The sentence in the description ("only 3.4.1 / 3.4.3 contain the tooltip sanitizer") means that both 3.4.1 and 3.4.3 have the fix.

Updates
Comments
Add the packages that ship the same Bootstrap JavaScript but are missing from this advisory.
Evidence (artifacts checked):